Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cilium BGPv1 Reconciler - Handle updated and deprecated Cidr fields for CiliumLoadBalancerIPPool #32694

Merged
merged 1 commit into from
May 31, 2024

Commits on May 30, 2024

  1. Cilium BGPv1 Reconciler - Handle updated and deprecated Cidr fields

    In cilium@27322f3, the CiliumLoadBalancerIPPool's field named "cidrs" was deprecated.  The documentation on https://docs.cilium.io/en/stable/network/lb-ipam/ provides an example of configuring a CiliumLoadBalancerIPPool using the field named "blocks".  While testing a BGP policy configured with the Advertised Path Attributes feature, I was not able to achieve the desired policy.  BGP attributes configured were not being applied.
    
    While discussing this in Cilium's Slack channel, it was pointed out that the BGPv1 reconciler was only aware of the deprecated field.
    
    This commit updates Cilium's BGPv1 reconciler to support both the deprecated and updated fields.
    
    Fixes: cilium#32693
    
    Signed-off-by: David Swafford <dswafford@coreweave.com>
    dswaffordcw committed May 30, 2024
    Configuration menu
    Copy the full SHA
    1241974 View commit details
    Browse the repository at this point in the history