Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Use upstream spire helm chart #32716

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ishuar
Copy link
Contributor

@ishuar ishuar commented May 25, 2024

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #30106

<!-- Use Upstream [SPIRE](https://github.com/spiffe/helm-charts-hardened/tree/main/charts/spire) Helm Chart-->

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 25, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 25, 2024
@ishuar ishuar force-pushed the feat/use-upstream-spire-helm-chart branch from 371c512 to 670bf66 Compare May 25, 2024 16:45
@maintainer-s-little-helper
Copy link

Commit ca8e049 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 25, 2024
@ishuar ishuar force-pushed the feat/use-upstream-spire-helm-chart branch from ca8e049 to 670bf66 Compare May 25, 2024 16:56
@maintainer-s-little-helper
Copy link

Commit ca8e049 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link

Commit 8bbab23 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

Signed-off-by: ishuar <ishansharma887@gmail.com>
Signed-off-by: ishuar <ishansharma887@gmail.com>
@ishuar ishuar force-pushed the feat/use-upstream-spire-helm-chart branch from 8bbab23 to 5dd5065 Compare May 25, 2024 17:00
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. kind/community-contribution This was a contribution made by a community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFP: SPIRE Helm Chart
1 participant