cni: Reserve local ports for DNS proxy even if IPv6 is disabled #32725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aids in troubleshooting, as the list of ports is not visible anywhere else in the sysdump. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
This fixes a bug where the port reservation of ports which can conflict with transparent DNS proxy where only reserved if IPv6 was enabled. The call to `reserveLocalIPPorts` was accidentally added in the "IPv6-only" branch. This commit fixes that by unconditionally reserving local ports. Fixes: 11fe7cc ("cilium-cni: Reserve ports that can conflict with transparent DNS proxy") Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
area/cni
3 tasks
|
/test |
tklauser
approved these changes
May 28, 2024
julianwiedmann
added
the
area/proxy
maintainer-s-little-helper
bot
added
the
ready-to-merge
joamaki
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.17
joamaki
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.12
joamaki
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.6
github-actions
bot
added
backport-done/1.13
github-actions
bot
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.12
github-actions
bot
added
backport-done/1.15
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the port reservation of ports which can conflict with transparent DNS proxy where only reserved if IPv6 was enabled.
The call to
reserveLocalIPPortswas accidentally added in the "IPv6-only" branch. This commit fixes that by unconditionally reserving local ports.Fixes: 11fe7cc ("cilium-cni: Reserve ports that can conflict with transparent DNS proxy")