-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.15: Revert the change to the golang image version of hubble-relay #32732
v1.15: Revert the change to the golang image version of hubble-relay #32732
Conversation
/test-backport-1.15 |
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
a08d128
to
5c56009
Compare
@@ -446,7 +446,7 @@ jobs: | |||
--sysdump-output-filename "cilium-sysdump-${{ matrix.name }}-<ts>" \ | |||
--junit-file "cilium-junits/${{ env.job_name }} (${{ join(matrix.*, ', ') }}).xml" \ | |||
--junit-property github_job_step="Run tests upgrade 2 (${{ join(matrix.*, ', ') }})" \ | |||
\$EXTRA | |||
$EXTRA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this gets rid of unnecessary escaping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeah. I was thinking it is just a cosmetic thing, but actually it was mistakenly escaped.
In the upstream, it is fixed:
$EXTRA |
/test-backport-1.15 |
In my env, the command `tail -n+4 CHANGELOG.md | sed '/^## v.*$/q'` includes the version header of the previous command. Grep it out. % tail -n+4 CHANGELOG.md | sed '/^## v.*$/q' Summary of Changes ------------------ **Minor Changes:** ... * Revert golang image version of hubble-relay (cilium/cilium#32732, @YutaroHayakawa) ## v1.15.5 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
In my env, the command `tail -n+4 CHANGELOG.md | sed '/^## v.*$/q'` includes the version header of the previous command. Grep it out. % tail -n+4 CHANGELOG.md | sed '/^## v.*$/q' Summary of Changes ------------------ **Minor Changes:** ... * Revert golang image version of hubble-relay (cilium/cilium#32732, @YutaroHayakawa) ## v1.15.5 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
I mistakenly bumped up the golang image version in hubble-relay Dockerfile in the v1.15 backport. Revert it. Also, let me piggy-back the very small
cosmetic changebugfix for GHA.Fixes: #32691