Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renovate: update k8s dependencies automatically #33236

Merged
merged 2 commits into from
Jun 20, 2024
Merged

renovate: update k8s dependencies automatically #33236

merged 2 commits into from
Jun 20, 2024

Conversation

aanm
Copy link
Member

@aanm aanm commented Jun 18, 2024

See per commit basis

@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jun 18, 2024
@aanm aanm requested a review from joestringer June 18, 2024 15:21
@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from 70c81e4 to cf59c3b Compare June 18, 2024 15:25
@aanm aanm had a problem deploying to release-base-images June 18, 2024 15:25 — with GitHub Actions Failure
@joestringer
Copy link
Member

joestringer commented Jun 18, 2024 •
edited
Loading

Is automerge going to work for cilium/cilium with the pace of the repo?

https://docs.renovatebot.com/key-concepts/automerge/

... ensure that Renovate has had the time to run once in a state where tests have passed and the branch is up-to-date with its base branch. If you or others keep committing to the default branch then Renovate cannot find a suitable gap to automerge into!

(Though we could always structure some process around this, for instance, "no-merge-mondays" where we try to ensure the renovate PRs get merged and try to avoid merging other PRs until renovate PRs are processed at the start of the week)

EDIT: We can always try this first, then adjust based on how well it works.

joestringer
joestringer reviewed Jun 18, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from cf59c3b to a25679d Compare June 18, 2024 19:19
@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from a25679d to 9cdfc43 Compare June 18, 2024 19:46
@aanm aanm had a problem deploying to release-base-images June 18, 2024 19:46 — with GitHub Actions Failure
@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from 9cdfc43 to 12783d0 Compare June 18, 2024 20:30
@aanm aanm had a problem deploying to release-base-images June 18, 2024 20:30 — with GitHub Actions Failure
@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from 12783d0 to cfbf6fc Compare June 18, 2024 20:49
@aanm aanm temporarily deployed to release-base-images June 18, 2024 20:49 — with GitHub Actions Inactive
@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from cfbf6fc to e2acc3b Compare June 19, 2024 09:58
@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from e2acc3b to 1490b4e Compare June 19, 2024 09:59
@aanm
Copy link
Member Author

aanm commented Jun 19, 2024

/test

@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from 1490b4e to b34c4a5 Compare June 19, 2024 10:03
@aanm
Copy link
Member Author

aanm commented Jun 19, 2024

/test

@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from b34c4a5 to 818d60d Compare June 19, 2024 14:52
@aanm
Copy link
Member Author

aanm commented Jun 19, 2024

Is automerge going to work for cilium/cilium with the pace of the repo?

https://docs.renovatebot.com/key-concepts/automerge/

... ensure that Renovate has had the time to run once in a state where tests have passed and the branch is up-to-date with its base branch. If you or others keep committing to the default branch then Renovate cannot find a suitable gap to automerge into!

(Though we could always structure some process around this, for instance, "no-merge-mondays" where we try to ensure the renovate PRs get merged and try to avoid merging other PRs until renovate PRs are processed at the start of the week)

EDIT: We can always try this first, then adjust based on how well it works.

Yeah I saw this as well. Unfortunately I couldn't see the auto merge happening on my private fork to see it working so I think we will need to test it out to see how to process looks like as well for the trigger sentence to run the tests.

@aanm aanm marked this pull request as ready for review June 19, 2024 14:54
@aanm aanm requested review from a team as code owners June 19, 2024 14:54
@aanm aanm requested review from a team as code owners June 19, 2024 14:54
@aanm
Copy link
Member Author

aanm commented Jun 19, 2024

/test

@aanm aanm enabled auto-merge June 19, 2024 14:55
kaworu
kaworu approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hubble Relay changes LGTM

@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from 818d60d to feafd31 Compare June 19, 2024 18:50
@aanm
Copy link
Member Author

aanm commented Jun 19, 2024

/test

aanm added 2 commits June 20, 2024 13:08
@aanm
images/builder: add /.cache directory
4493c29 
The builder image is used to generate Kubernetes manifests and some Go code
for Kubernetes clients. Currently, Docker run commands are executed as the
root user inside the container, resulting in files being created with the
root UID. This prevents the user who executed the Docker run command from
managing these files.

Running the Docker container with the executing user's UID causes "go run"
commands to fail due to insufficient permissions to write to the /.cache
directory. To resolve this, we need to create a /.cache directory with write
permissions for all users.

Signed-off-by: André Martins <andre@cilium.io>
@aanm
renovate: update k8s dependencies automatically
b46cd54 
Now that we are running renovate as a GH action this allow us to
run postUpgradeTasks. Some of these upgrade tasks will be to generate
some manifests or k8s go client files after we update the k8s
dependencies.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/renovate-auto-update-k8s branch from feafd31 to b46cd54 Compare June 20, 2024 11:09
@aanm aanm temporarily deployed to release-base-images June 20, 2024 11:09 — with GitHub Actions Inactive
@aanm aanm changed the title renovate: update k8s dependencies and add auto-merge renovate: update k8s dependencies Jun 20, 2024
@aanm aanm changed the title renovate: update k8s dependencies renovate: update k8s dependencies automatically Jun 20, 2024
@aanm
Copy link
Member Author

aanm commented Jun 20, 2024

/test

@joestringer joestringer mentioned this pull request Jun 20, 2024
Merged
@aanm aanm added this pull request to the merge queue Jun 20, 2024
Merged via the queue into cilium:main with commit c276888 Jun 20, 2024
69 of 70 checks passed
@aanm aanm deleted the pr/renovate-auto-update-k8s branch June 20, 2024 19:07
@joestringer joestringer mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@joestringer joestringer joestringer approved these changes

@christarazi christarazi christarazi approved these changes

@borkmann borkmann Awaiting requested review from borkmann borkmann is a code owner automatically assigned from cilium/build

@aditighag aditighag Awaiting requested review from aditighag aditighag is a code owner automatically assigned from cilium/contributing

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanm @joestringer @kaworu @christarazi