[v1.13] health: only launch /hello after host datapath is ready #33253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.13
|
/test-backport-1.13 |
|
/test-1.16-4.19 Error authenticating to ghcr |
|
/test-1.16-4.19 |
ti-mo
force-pushed
the
tb/v1.13-wait-hostdp
branch
from
f8a07fe
to
2c5d85e
Compare
youngnick
approved these changes
Jun 25, 2024
|
/test-backport-1.13 Job 'Cilium-PR-K8s-1.19-kernel-4.19' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-4.19/579/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
Blocked on #33376 to fix a couple of workflows. |
[ upstream commit 8c97a21 ] The code to restore endpoint state checks for the presence of bpf_host.o to determine whether the host endpoint ID needs to be restored. Use ep.IsHost instead to decouple the restore process from what the loader is doing under the covers. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
[ upstream commit 916a2ce ] Delay starting the /hello endpoint until we've loaded the host datapath at least once. This means that the presence of /health can be used to infer not only that the cilium unix socket API is up but also that the datapath can do basic packet processing. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
[ upstream commit acf3141 ] [ backporter's notes: only needed a single line from this patch, the rest was not compatible ] BPF regeneration writes state into a new temporary directory. Once it has succeeded we need to swap the old and new directory. This is currently achieved by "backing up" the current state by renaming the directory. This code has a bunch of corner cases around cleaning up old directories and so on which are necessary since the synchronization isn't truly atomic. Instead, use the RENAME_EXCHANGE flag to atomically exchange the two existing directories. Also use hard links to retain existing state so that killing the agent during a synchronization doesn't lead to corruption. Signed-off-by: Lorenz Bauer <lmb@isovalent.com> Signed-off-by: Timo Beckers <timo@isovalent.com>
|
/test-backport-1.13 Job 'Cilium-PR-K8s-1.20-kernel-4.19' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.19/580/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. Job 'Cilium-PR-K8s-1.17-kernel-4.19' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.17-kernel-4.19/591/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
/test-1.17-4.19 |
|
/test-1.16-4.19 |
|
/test-1.20-4.19 |
|
/test-1.17-4.19 |
3 similar comments
|
/test-1.17-4.19 |
|
/test-1.17-4.19 |
|
/test-1.17-4.19 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
dylandreimerink
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting some host endpoint-related fixes to hopefully address
HOST_EP_ID 65535being rendered into bpf_lxc's ep_config.h.