Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.13] bpf: lb: un-break terminating backends for service without backend #33276

Draft
wants to merge 2 commits into
base: v1.13
Choose a base branch
from

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Jun 20, 2024

Manual backport of

Once this PR is merged, a GitHub action will update the labels of these PRs:

 31840

[ upstream commit 0de6f0f ]

[ backporter's notes: add the ->count checks in slightly different
  locations, as we're missing a bunch of LB cleanup PRs. ]

Continue to forward traffic for established connections, even when a
service loses its last active backends.

This needs a small adjustment in a BPF test that was relying on this
behaviour.

Fixes: 1835011 ("bpf: drop SVC traffic if no backend is available")
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
[ upstream commit 7ece278 ]

[ backporter's notes: open-code all the non-existent helpers ]

Once a LB connection has been established, we expect to continue using
its CT entry to obtain the backend. Even if the backend is in terminating
state, and the service has lost all of its backends.

Keeping this separate from the fix, in case we can't easily backport.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Jun 20, 2024
@julianwiedmann julianwiedmann changed the title V1.13 terminating backend [v1.13] bpf: lb: un-break terminating backends for service without backend Jun 20, 2024
@julianwiedmann
Copy link
Member Author

/test-backport-1.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant