docs: Add Port Range Information #33389
Merged
+54
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanjsweet
added
the
release-note/misc
nathanjsweet
added
the
release-blocker/1.16
nathanjsweet
force-pushed
the
pr/nathanjsweet/port-range-documentation-updates
branch
from
08ac957
to
f183229
Compare
joestringer
reviewed
Jun 25, 2024
nathanjsweet
force-pushed
the
pr/nathanjsweet/port-range-documentation-updates
branch
from
f183229
to
6df75d8
Compare
nathanjsweet
force-pushed
the
pr/nathanjsweet/port-range-documentation-updates
branch
from
6df75d8
to
a46a3ad
Compare
joestringer
requested changes
Jun 27, 2024
There was a problem hiding this comment.
I think we should consolidate the restrictions around port ranges into the section where port ranges are introduced and described, and also avoid using notes so much (see this guidance in the docs).
- Port Ranges are now supported so it is removed from
the unsupported features table.
- DNS rules and L7 rules do not support port ranges yet.
Notes are added to call attention to this.
- Add a Port Range example.
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
nathanjsweet
force-pushed
the
pr/nathanjsweet/port-range-documentation-updates
branch
from
a46a3ad
to
8d73d50
Compare
tommyp1ckles
approved these changes
Jun 28, 2024
joestringer
approved these changes
Jun 28, 2024
|
/test |
joestringer
added
the
needs-backport/1.16
jibi
added
backport-pending/1.16
julianwiedmann
added
backport-done/1.16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- SCTP and Port Ranges are now supported, both are removed from the unsupported features table.Edit: