Fix l3-dependent L4/L7 rules applying to CIDR egress traffic #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
pending-review
sig/datapath
tgraf
requested changes
Mar 31, 2018
bpf/lib/l4.h
Outdated
| allowed = 0; | ||
| #endif /* CFG_L4_EGRESS */ | ||
| #ifdef CFG_L3L4__EGRESS | ||
| if (l3dependent) { |
There was a problem hiding this comment.
Let's reset allowed and treat each call to BPF_L4_MAP() independently.
There was a problem hiding this comment.
Done, separated out into entirely different invocations.
joestringer
force-pushed
the
submit/l3dl4+cidr
branch
2 times, most recently
from
3b2d8e6
to
55ac034
Compare
tgraf
approved these changes
Mar 31, 2018
|
test-me-please |
eloycoto
approved these changes
Apr 2, 2018
Refactor the way that we generate CFG_L4_INGRESS and CFG_L4_EGRESS. An upcoming commit will split this into two, to differentiate l3-dependent L4 vs. L3-independent L4. Signed-off-by: Joe Stringer <joe@covalent.io>
L3-dependent L4 proxyport should only ever be found via the lookup in the label-based policy enforcement, and never be found via the CIDR-dependent L4 policy lookup. Split it out. Fixes: cilium#3414 Signed-off-by: Joe Stringer <joe@covalent.io>
When policy import fails, print the poolicy as well. Signed-off-by: Joe Stringer <joe@covalent.io>
This will be reused in an upcoming commit. Signed-off-by: Joe Stringer <joe@covalent.io>
Signed-off-by: Joe Stringer <joe@covalent.io>
Add a test that introduces an L3-dependent L7 in-cluster egress rule which denies all traffic, plus a separate L3 CIDR egress rule. External access should not occur via the proxy. This detects issue cilium#3414. Signed-off-by: Joe Stringer <joe@covalent.io>
|
L3/L4 checks failed in CI but passed locally. I'm running all of the policies tests locally to see if anything crops up. |
joestringer
force-pushed
the
submit/l3dl4+cidr
branch
from
55ac034
to
e7e5517
Compare
|
test-me-please |
joestringer
added
the
release-note/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3414