Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed BPF templates in cilium-agent #354

Merged
merged 2 commits into from Mar 20, 2017
Merged

Embed BPF templates in cilium-agent #354

merged 2 commits into from Mar 20, 2017

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Mar 20, 2017 •
edited by aanm


  •  File: .travis/prepare.sh:L11-18
  • Why doesn't this belong to vendor?
  • It's a binary, we only need it at development time.
  • Can you document that somewhere? We already need go-swagger and now this go-bindata as well
  • I will add this to the developer docs.

  

@tgraf
bpf: Move go code in bpf/ into pkg/
c3035b5 
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
cilium: Embed bpf templates in cilium-agent binary
2d61a2c 
This avoids requiring to install the BPF template files in
/usr/lib/cilium and embeds these template files in the binary
instead to ease distribution.

Related: #324

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added kind/enhancement This would improve or streamline existing functionality. release blocker labels Mar 20, 2017
@tgraf tgraf added this to the 0.8 release milestone Mar 20, 2017
@tgraf tgraf force-pushed the bpf-cleanup2 branch 3 times, most recently from a79ebe8 to 2d61a2c Compare March 20, 2017 01:44
@tgraf tgraf requested a review from aanm March 20, 2017 02:16
@tgraf tgraf mentioned this pull request Mar 20, 2017
Closed
aanm
aanm reviewed Mar 20, 2017
View reviewed changes
.travis/prepare.sh
@@ -11,5 +11,7 @@ sudo tar -C /usr/local -xJf $CLANG_FILE
sudo ln -s /usr/local/$CLANG_DIR /usr/local/clang
rm $CLANG_FILE

go get -u github.com/jteeuwen/go-bindata/...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't this belong to vendor?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a binary, we only need it at development time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document that somewhere? We already need go-swagger and now this go-bindata as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add this to the developer docs.

@tgraf tgraf mentioned this pull request Mar 20, 2017
Merged
6 tasks
@tgraf tgraf merged commit e086c90 into master Mar 20, 2017
@tgraf tgraf deleted the bpf-cleanup2 branch March 20, 2017 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/enhancement This would improve or streamline existing functionality.
Projects
None yet
Milestone
0.8 release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgraf @aanm