Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not include dummy header files in distribution #408

Merged
merged 2 commits into from Mar 22, 2017
Merged

Do not include dummy header files in distribution #408

merged 2 commits into from Mar 22, 2017

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Mar 22, 2017 •
edited

Fixes: #407


 

@tgraf
bindata.go: Do not include dummy headers in binary
fbc6114 
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
Update bindata.go
2479097 
With dummy header files excluded

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added kind/bug This is a bug in the Cilium logic. release blocker labels Mar 22, 2017
@tgraf tgraf added this to the 0.8 release milestone Mar 22, 2017
@tgraf tgraf requested a review from borkmann March 22, 2017 13:54
borkmann
borkmann approved these changes Mar 22, 2017
View reviewed changes
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tgraf tgraf merged commit 2f6a41c into master Mar 22, 2017
@tgraf tgraf deleted the bindata-ignore branch March 22, 2017 14:20
@tgraf tgraf mentioned this pull request Mar 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic.
Projects
None yet
Milestone
0.8 release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgraf @borkmann