-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename L7 fields in L4 policy #500
Conversation
golang: Redirect => L7Parser RedirectPort => L7RedirectPort Rules => L7Rules json: redirect => l7-parser redirect-port => l7-redirect-port rules => l7-rules Signed-off-by: Thomas Graf <thomas@cilium.io>
@@ -8,8 +8,8 @@ | |||
"l4": [{ | |||
"out-ports": [{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename the out-ports
and in-ports
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do that next.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments inline
golang:
Redirect => L7Parser
RedirectPort => L7RedirectPort
Rules => L7Rules
json:
redirect => l7-parser
redirect-port => l7-redirect-port
rules => l7-rules
Signed-off-by: Thomas Graf thomas@cilium.io
out-ports
andin-ports
as well?