Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cilium pre-flight check #6067

Merged
merged 4 commits into from Nov 6, 2018
Merged

Add Cilium pre-flight check #6067

merged 4 commits into from Nov 6, 2018

Conversation

aanm
Copy link
Member

@aanm aanm commented Oct 26, 2018 •
edited by tgraf

This will allow users to pre-download the Cilium image for the versions they will try to upgrade.

Add optional DaemonSet for pre-flight checks before performing upgrades

This change is Reviewable

@aanm aanm added kind/enhancement This would improve or streamline existing functionality. pending-review sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Oct 26, 2018
@aanm aanm added this to the 1.4-feature milestone Oct 26, 2018
@aanm aanm added this to Commited in 1.4 via automation Oct 26, 2018
@aanm aanm requested a review from a team as a code owner October 26, 2018 15:53
@aanm aanm requested a review from a team October 26, 2018 15:53
@aanm aanm added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Oct 26, 2018
@aanm aanm requested a review from a team as a code owner October 26, 2018 16:39
@aanm
Copy link
Member Author

aanm commented Oct 26, 2018

test-me-please

@ianvernon
Copy link
Member

Can you elaborate on why this needs backport to v1.3?

@aanm
Copy link
Member Author

aanm commented Oct 26, 2018

@ianvernon for people that want to upgrade to 1.3

ianvernon
ianvernon reviewed Oct 26, 2018
View reviewed changes
Copy link
Member

@ianvernon ianvernon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issues with the overall change. This provides a strong foundation for extending such preflight checks in the future :D

Only one documentation nit.

examples/kubernetes/1.10/cilium-pre-flight.yaml
- cilium
topologyKey: "kubernetes.io/hostname"
containers:
- image: docker.io/cilium/cilium:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was slightly confused what this was doing until I realized that be being ran, this was pulling the image :)

Documentation/install/upgrade.rst Outdated Show resolved Hide resolved
tgraf
tgraf requested changes Oct 28, 2018
View reviewed changes
Documentation/install/upgrade.rst Outdated Show resolved Hide resolved
Documentation/install/upgrade.rst Outdated Show resolved Hide resolved
@aanm
Copy link
Member Author

aanm commented Oct 29, 2018

test-me-please

@aanm aanm requested a review from tgraf October 29, 2018 10:30
@aanm
Copy link
Member Author

aanm commented Oct 29, 2018

test-me-please

@tgraf tgraf moved this from Commited to In Progress in 1.4 Oct 29, 2018
@aanm
Copy link
Member Author

aanm commented Oct 30, 2018

test-me-please

@aanm
Copy link
Member Author

aanm commented Nov 1, 2018

test-me-please

@coveralls
Copy link

coveralls commented Nov 1, 2018 •
edited

Coverage Status

Coverage decreased (-0.05%) to 42.769% when pulling 1d9438a on pr/add-pre-flight-checker into 0df76e8 on master.

@aanm
Copy link
Member Author

aanm commented Nov 1, 2018

test-upstrea-k8s

@aanm
Copy link
Member Author

aanm commented Nov 1, 2018

test-upstream-k8s

@aanm
examples/kubernetes: simplify makefile
f817cff 
Signed-off-by: André Martins <andre@cilium.io>
@aanm
Copy link
Member Author

aanm commented Nov 2, 2018

test-me-please

@aanm
examples/kubernetes: add cilium-pre-flight DaemonSet
826b8bd 
This will allow to pre download Cilium images before performing an
upgrade.

Signed-off-by: André Martins <andre@cilium.io>
@aanm
docs: add pre-flight check instructions
b2d631a 
Signed-off-by: André Martins <andre@cilium.io>
@aanm
test: add tests for cilium pre-flight daemonset
1d9438a 
Signed-off-by: André Martins <andre@cilium.io>
@aanm
Copy link
Member Author

aanm commented Nov 2, 2018

test-me-please

@aanm aanm removed the sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. label Nov 2, 2018
@aanm
Copy link
Member Author

aanm commented Nov 2, 2018

test-me-please

@aanm
Copy link
Member Author

aanm commented Nov 3, 2018

test-missed-k8s

1 similar comment
@aanm
Copy link
Member Author

aanm commented Nov 5, 2018

test-missed-k8s

@aanm
Copy link
Member Author

aanm commented Nov 5, 2018

@tgraf PTAL

@tgraf tgraf merged commit fc7eeef into master Nov 6, 2018
1.4 automation moved this from In Progress to Done Nov 6, 2018
@tgraf tgraf deleted the pr/add-pre-flight-checker branch November 6, 2018 15:30
@ianvernon ianvernon mentioned this pull request Nov 13, 2018
Merged
@ianvernon ianvernon added this to Proposed in 1.3.1 via automation Dec 5, 2018
@ianvernon ianvernon moved this from Proposed to Done in 1.3.1 Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianvernon ianvernon ianvernon left review comments

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/enhancement This would improve or streamline existing functionality. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.3.1
Done
1.4
  
Done
Milestone
1.4-feature
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanm @ianvernon @coveralls @tgraf