Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: debuginfo: Read file directly instead of using cat #6199

Merged
merged 1 commit into from Nov 7, 2018
Merged

daemon: debuginfo: Read file directly instead of using cat #6199

merged 1 commit into from Nov 7, 2018

Conversation

vadorovsky
Copy link
Member

@vadorovsky vadorovsky commented Nov 7, 2018 •
edited by tgraf

Signed-off-by: Michal Rostecki mrostecki@suse.de

This change is Reviewable

@vadorovsky vadorovsky requested a review from a team November 7, 2018 11:21
@vadorovsky
Copy link
Member Author

test-me-please

@coveralls
Copy link

coveralls commented Nov 7, 2018 •
edited

Coverage Status

Coverage decreased (-0.01%) to 43.655% when pulling e041d61 on mrostecki:debuginfo-readfile into 541280e on cilium:master.

@vadorovsky vadorovsky changed the title daemon: debuginfo: Read file directly instead of using cat [WIP] daemon: debuginfo: Read file directly instead of using cat Nov 7, 2018
@vadorovsky
daemon: debuginfo: Read file directly instead of using cat
e041d61 
Signed-off-by: Michal Rostecki <mrostecki@suse.de>
@vadorovsky vadorovsky changed the title [WIP] daemon: debuginfo: Read file directly instead of using cat daemon: debuginfo: Read file directly instead of using cat Nov 7, 2018
@vadorovsky
Copy link
Member Author

test-me-please

@vadorovsky
Copy link
Member Author

Unrelated error

@vadorovsky
Copy link
Member Author

test-me-please

@ianvernon ianvernon added pending-review area/daemon Impacts operation of the Cilium daemon. labels Nov 7, 2018
@tgraf tgraf added this to In Progress in 1.4 via automation Nov 7, 2018
@tgraf tgraf added this to the 1.4-feature milestone Nov 7, 2018
@tgraf tgraf merged commit 2f4f941 into cilium:master Nov 7, 2018
1.4 automation moved this from In Progress to Done Nov 7, 2018
@vadorovsky vadorovsky deleted the debuginfo-readfile branch November 8, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@tgraf tgraf tgraf approved these changes

@ianvernon ianvernon ianvernon approved these changes

Assignees
No one assigned
Labels
area/daemon Impacts operation of the Cilium daemon.
Projects
No open projects
1.4
  
Done
Milestone
1.4-feature
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vadorovsky @coveralls @joestringer @tgraf @ianvernon