Fix addition/deletion order when updating endpoint labels #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pure cleanup, no code changes. Signed-off-by: André Martins <andre@cilium.io>
If the user wanted to modify the existing labels of an endpoint he could add and delete the same label in the same command (e.g.: cilium endpoint labels 123 --add foo=bar --del foo=bar). However, the deletion operation would follow the addition operation which means the label foo=bar would never be added to endpoint. This commits changes swaps the order of those operations which means for thee same label set on the same command for both operatons, the label will be added to the enpoint. Signed-off-by: André Martins <andre@cilium.io>
|
@aanm I reworded some of the commits, please confirm if accurate. |
aanm
reviewed
May 4, 2017
| d.conf.ValidLabelPrefixesMU.RUnlock() | ||
|
|
||
| if len(addLabels) == 0 || len(delLabels) == 0 { | ||
| return NewPutEndpointIDLabelsOK() | ||
| if len(addLabels) == 0 && len(delLabels) == 0 { |
There was a problem hiding this comment.
There was this small thing changed.
aanm
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.