bpf/init.sh: More robust deletion of routes. #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the 'dev' and 'via' options from route deletion commands, so
that routes will be deleted regardless of what 'dev' or 'via'
configuration they have. Without this change it is possible for a
conflicting route to exist which will not get removed and then the
following route add fails due to conflicting route already existing.
In the specific instance triggering this change there was a
conflicting route:
10.11.0.1 dev enp0s8 scope link
Which was not removed by:
$ ip route del 10.11.0.1/32 dev cilium_host
so that the following route add failed:
$ ip route add 10.11.0.1/32 dev cilium_host
RTNETLINK answers: File exists
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
borkmann
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the 'dev' and 'via' options from route deletion commands, so
that routes will be deleted regardless of what 'dev' or 'via'
configuration they have. Without this change it is possible for a
conflicting route to exist which will not get removed and then the
following route add fails due to conflicting route already existing.
In the specific instance triggering this change there was a
conflicting route:
Which was not removed by:
so that the following route add failed:
Signed-off-by: Jarno Rajahalme jarno@covalent.io