Cleanup cilium-calls map #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 16, 2017
pkg/endpoint/endpoint.go
Outdated
| return bpf.MapPath(CallsMapName + strconv.Itoa(id)) | ||
| } | ||
|
|
||
| // CallsMapPath returns the path to cilium tail calls map of an endpoint. |
There was a problem hiding this comment.
comment on exported method Endpoint.CallsMapPathLocked should be of the form "CallsMapPathLocked ..."
| @@ -674,6 +677,15 @@ func (e *Endpoint) PolicyMapPathLocked() string { | |||
| return PolicyMapPath(int(e.ID)) | |||
| } | |||
|
|
|||
| func CallsMapPath(id int) string { | |||
There was a problem hiding this comment.
exported function CallsMapPath should have comment or be unexported
pkg/endpoint/endpoint.go
Outdated
| @@ -158,6 +158,9 @@ const ( | |||
| StateReady = string(models.EndpointStateReady) | |||
| // StateRegenerating specifies when the endpoint is being regenerated. | |||
| StateRegenerating = string(models.EndpointStateRegenerating) | |||
|
|
|||
| // Base prefix for EP specific call map. | |||
There was a problem hiding this comment.
comment on exported const CallsMapName should be of the form "CallsMapName ..."
tgraf
approved these changes
May 16, 2017
|
Ok, I fix these two comments up in the process. |
cilium_calls map is the only map in cilium that is currently marked as PIN_OBJECT_NS. Issue is that cilium daemon currently does not clean this up during EP removal. Over time, this consumes a bit of memory since the tail call map holds programs that hold maps itself, so f.e. even if we removed the CT maps from the BPF fs, they can still hold a ref in the kernel by one of the tail called programs and as such cannot be cleaned. Move them into PIN_GLOBAL_NS with the EP id appended in the name, and trigger removal once EP is deleted. Signed-off-by: Daniel Borkmann <daniel@cilium.io>
Signed-off-by: Daniel Borkmann <daniel@cilium.io>
borkmann
force-pushed
the
447-cilium-calls
branch
from
b412616
to
73ed628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.