Add option to always allow localhost to reach endpoints #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new option `--allow-localhost { auto | always | policy }` defines the
policy on how to determine whether the localhost should be able to reach
local endpoints. The default is auto which means:
- "always" when run in a Kubernetes environment
- "policy" in all other environments
Fixes: #748
Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
added
kind/enhancement
houndci-bot
reviewed
May 18, 2017
daemon/daemon.go
Outdated
| @@ -202,6 +202,12 @@ func (d *Daemon) DryModeEnabled() bool { | |||
| return d.conf.DryMode | |||
| } | |||
|
|
|||
| // AllowLocalhost returns true if the daemon has the option set that localhost | |||
There was a problem hiding this comment.
comment on exported method Daemon.AlwaysAllowLocalhost should be of the form "AlwaysAllowLocalhost ..."
tgraf
force-pushed
the
allow-localhost
branch
2 times, most recently
from
3a1a695
to
d11026d
Compare
aanm
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new option
--allow-localhost { auto | always | policy }defines thepolicy on how to determine whether the localhost should be able to reach
local endpoints. The default is auto which means:
Fixes: #748