daemon: add kvstore-opt flag for kvstore config #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianvernon
force-pushed
the
623-kvstore-opts
branch
from
b5c737f
to
8f46d32
Compare
Add kvstore-opt flag, which maps a key (configuration flag) to a value. This results in only needing one flag in the CLI for key-value store related configuration, as opposed to many different flags for each different key-value. If any key is provided that maps to a different key-value store than the key-value store provided to the CLI, the daemon exits. We also ensure that the user-provided flags are supported flags; if the flag is not supported, the daemon exits. Remove the consul, etcd-config-path, etcd flags as valid options for the daemon. Signed-off by: Ian Vernon <ian@covalent.io>
ianvernon
force-pushed
the
623-kvstore-opts
branch
from
8f46d32
to
59bd97c
Compare
tgraf
approved these changes
May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kvstore-opt flag, which maps a key (configuration flag) to a value.
This results in only needing one flag in the CLI for key-value store
related configuration, as opposed to many different flags for each
different key-value. If any key is provided that maps to a different
key-value store than the key-value store provided to the CLI, the daemon
exits. We also ensure that the user-provided flags are supported flags;
if the flag is not supported, the daemon exits. Remove the consul,
etcd-config-path, etcd flags as valid options for the daemon.
Signed-off by: Ian Vernon ian@covalent.io
Fixes: #623