Consider all labels by default when deriving security identity #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgraf
added
the
kind/enhancement
tgraf
changed the title
aanm
requested changes
May 29, 2017
| if podName := k8sDockerLbls.GetPodName(allLabels); podName != "" { | ||
| k8sNormalLabels, err := d.fetchK8sLabels(allLabels) | ||
| if err != nil { | ||
| log.Warningf("Error while getting kubernetes labels: %s", err) | ||
| } else if k8sNormalLabels != nil { | ||
| k8sLbls = labels.Map2Labels(k8sNormalLabels, k8s.LabelSource) | ||
|
|
There was a problem hiding this comment.
We still need to store the io.kubernetes.pod.namespace here.
pkg/labels/filter.go
Outdated
| Prefix: k8s.PodNamespaceLabel, | ||
| Source: k8s.LabelSource, | ||
| Ignore: true, | ||
| Prefix: "io.kubernetes", | ||
| }, |
There was a problem hiding this comment.
Also ignore k8s.io/kubernetes/pkg/apis/extensions/DefaultDeploymentUniqueLabelKey or "pod-template-hash"
- Move into pkg/labels/ - No need to take lock Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
Instead of whitelisting individual label prefixes by default, consider all labels except "io.kubernetes*" to avoid including pod-name hash, timestamps, grace periods, etc. Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
force-pushed
the
take-all-labels
branch
2 times, most recently
from
8d3995d
to
a15ada7
Compare
aanm
approved these changes
May 30, 2017
|
For future reference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.