endpoint: factor out waiting for first regeneration during creation into separate function #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianvernon
added
pending-review
kind/cleanup
houndci-bot
reviewed
Aug 28, 2019
pkg/endpoint/endpoint.go
Outdated
| @@ -2007,3 +2007,106 @@ func (e *Endpoint) Delete(monitor monitorOwner, ipam ipReleaser, manager endpoin | |||
|
|
|||
| return errs | |||
| } | |||
|
|
|||
| type ContainerStartFunc func() | |||
There was a problem hiding this comment.
exported type ContainerStartFunc should have comment or be unexported
|
test-me-please |
ianvernon
force-pushed
the
pr/ianvernon/hide-endpoint-creation
branch
from
4eb95b1
to
aab062a
Compare
|
test-me-please |
ianvernon
force-pushed
the
pr/ianvernon/hide-endpoint-creation
branch
from
aab062a
to
fc4d0bf
Compare
|
test-me-please |
vadorovsky
approved these changes
Aug 30, 2019
raybejjani
suggested changes
Aug 30, 2019
aanm
previously requested changes
Aug 30, 2019
ianvernon
force-pushed
the
pr/ianvernon/hide-endpoint-creation
branch
2 times, most recently
from
5f9a02f
to
88b8676
Compare
|
test-me-please |
raybejjani
approved these changes
Sep 3, 2019
…nto separate function This hides a lot of endpoint internals from the \`daemon\`. Signed-off by: Ian Vernon <ian@cilium.io>
ianvernon
force-pushed
the
pr/ianvernon/hide-endpoint-creation
branch
from
88b8676
to
1ef1c6a
Compare
|
test-me-please |
|
test-me-please |
|
Merging; all comments have been addressed. |
aanm
added
the
release-note/misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides a lot of endpoint internals from the `daemon`.
Signed-off by: Ian Vernon ian@cilium.io
I have a branch in which I have done way more refactoring of this code, but I think this is a good first step into hiding endpoint internals from the Daemon during Endpoint creation.
This change is