endpoint: refactor how default policy enforcement configuration is performed #9120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 3, 2019
pkg/endpoint/endpoint.go
Outdated
| @@ -2007,3 +1978,20 @@ func (e *Endpoint) Delete(monitor monitorOwner, ipam ipReleaser, manager endpoin | |||
|
|
|||
| return errs | |||
| } | |||
|
|
|||
| func (e *Endpoint) SetDefaultPolicyConfiguration(restore bool) { | |||
There was a problem hiding this comment.
exported method Endpoint.SetDefaultPolicyConfiguration should have comment or be unexported
ianvernon
force-pushed
the
pr/ianvernon/refactor-default-policy-enforce-config-endpoint
branch
from
dc2286f
to
6f301db
Compare
|
test-me-please |
raybejjani
approved these changes
Sep 5, 2019
…rformed Hide Endpoint locking semantics. Signed-off by: Ian Vernon <ian@cilium.io>
ianvernon
force-pushed
the
pr/ianvernon/refactor-default-policy-enforce-config-endpoint
branch
from
6f301db
to
a492bf4
Compare
|
test-me-please |
|
Checkout from Git failed: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/14844/execution/node/29/log/ |
|
test-me-please |
|
More apt fun: |
|
test-me-please |
3 similar comments
|
test-me-please |
|
test-me-please |
|
test-me-please |
ianvernon
deleted the
pr/ianvernon/refactor-default-policy-enforce-config-endpoint
branch
joestringer
added
the
release-note/misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide Endpoint locking semantics.
Signed-off by: Ian Vernon ian@cilium.io
This change is