pkg/lock: fix StoppableWaitGroup tests #9465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the WaitGroup Add function might be executed after Wait() is called golang will return a panic. > WaitGroup is reused before previous Wait has returned To avoid doing it so, one must Add the number of go routines that will execute Done() before those go routines are scheduled. Fixes: a34e501 ("use StoppableWaitGroup to make sure k8s caches were synced with datapath") Signed-off-by: André Martins <andre@cilium.io>
aanm
added
pending-review
kind/bug/CI
|
test-me-please |
brb
approved these changes
Oct 21, 2019
joestringer
added
the
release-note/misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the WaitGroup Add function might be executed after Wait()
is called golang will return a panic.
To avoid doing it so, one must Add the number of go routines that will
execute Done() before those go routines are scheduled.
Fixes: a34e501 ("use StoppableWaitGroup to make sure k8s caches were synced with datapath")
Signed-off-by: André Martins andre@cilium.io
This change is