Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: update to account for new CNPNodeStatus capabilities #9531

Merged
merged 2 commits into from Oct 30, 2019

Conversation

ianvernon
Copy link
Member

@ianvernon ianvernon commented Oct 30, 2019

Recent work was merged to offload CNPNodeStatus updates to the key-value store, which will be streamed to cilium-operator and then sent to kube-apiserver. Add documentation about the new prefix which is used in the key-value store, as well as for cilium-operator to list this as one of its scalability capabilities.

Signed-off by: Ian Vernon ian@cilium.io


This change is Reviewable

Ian Vernon added 2 commits October 30, 2019 15:17
Now that we write to the kvstore if k8s-handover is enabled for CNPNodeStatus
updates, , update the documentation accordingly about the new prefix we use for
CNPNodeStatus updates.

Signed-off by: Ian Vernon <ian@cilium.io>
Add `CiliumNetworkPolicyNodeStatus` update coordination capability which was
recently merged.

Signed-off by: Ian Vernon <ian@cilium.io>
@ianvernon ianvernon added pending-review area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. labels Oct 30, 2019
@ianvernon ianvernon added this to the 1.7 milestone Oct 30, 2019
@ianvernon ianvernon requested a review from a team as a code owner October 30, 2019 22:25
@ianvernon
Copy link
Member Author

test-docs-please

``cilium/state/cnpstatuses/v2/<UID>/<namespace>/<name>/<node>`` k8s.CNPNSWithMeta_
================================================================ ====================

.. _k8s.CNPNSWithMeta: https://godoc.org/github.com/cilium/cilium/pkg/k8s#CNPNSWithMeta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path on this makes me think it should probably be moved under a directory responsible for k8s APIs, but that's an entire aside for this PR.

@ianvernon ianvernon merged commit 0667ec4 into master Oct 30, 2019
@ianvernon ianvernon deleted the pr/ianvernon/add-cnpstatus-docs branch October 30, 2019 22:39
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 45.181% when pulling dd96320 on pr/ianvernon/add-cnpstatus-docs into 7393c2c on master.

@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants