Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run make for install/kubernetes/quick-start.yaml #9751

Merged
merged 1 commit into from Dec 17, 2019
Merged

Run make for install/kubernetes/quick-start.yaml #9751

merged 1 commit into from Dec 17, 2019

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Dec 12, 2019 •
edited by tgraf

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin.
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Running make in install/kubernetes dir produces a different file than the checked in version.

This change is Reviewable

@frelon
Running install/kubernetes/make produces a different version than che…
541e927 
…cked in file

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@gmail.com>
@frelon frelon requested a review from a team December 12, 2019 10:55
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 45.927% when pulling 541e927 on frelon:make-kubernetes-config into 078f19d on cilium:master.

@brb
Copy link
Member

brb commented Dec 16, 2019

test-me-please

brb
brb approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@brb brb mentioned this pull request Dec 16, 2019
Merged
@brb
Copy link
Member

brb commented Dec 16, 2019

A CI provisioning failure. Re-running.

@brb
Copy link
Member

brb commented Dec 16, 2019

test-me-please

@aanm aanm added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Dec 16, 2019
@brb
Copy link
Member

brb commented Dec 16, 2019

The provisioning failed again:

[2019-12-16T12:21:46.042Z]     k8s1-1.11: docker build --build-arg LOCKDEBUG=1 -f cilium-operator.Dockerfile -t "cilium/operator:"latest"" .
[2019-12-16T13:04:24.182Z] Cancelling nested steps due to timeout

@brb
Copy link
Member

brb commented Dec 16, 2019

test-me-please

@joestringer
Copy link
Member

CI provisioning issue again. Re-running.

@joestringer
Copy link
Member

test-me-please

aanm
aanm approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, priorityClassName was introduced in k8s 1.10. Cilium 1.7 only supports >= 1.11 so we can introduce it in the quick-install.yaml

@aanm aanm merged commit 5ccc3db into cilium:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frelon @coveralls @brb @joestringer @aanm