node: Remove the IPv6 prefix /96 constraint #9777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 17, 2019
|
test-me-please |
Previously, the DSR for IPv6 (aka the "--lb" feature) required the "--ipv6-range" to be /96. This was because the 113-128 bits of an IPv6 addr were used to store a global reverse NAT ID. As the "--lb" feature was removed, the constraint is no longer needed, thus it can be removed. Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
force-pushed
the
pr/brb/rm-ipv6-prefix-constraint
branch
from
3578324
to
abb8e33
Compare
brb
changed the title
Neither Node or Endpoint IDs are stored in an IPv6 address. Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added
pending-review
area/daemon
|
test-me-please |
joestringer
requested changes
Dec 17, 2019
There was a problem hiding this comment.
If we still have (and use) IPv6NodePrefixLen then I'm assuming that the prefix must still be /96 or shorter?
cilium/pkg/node/node_address.go
Lines 125 to 129 in 131fb89
aanm
approved these changes
Dec 17, 2019
|
test-me-please |
@joestringer Good question. This is for a different case when an IPv6 alloc range is derived from I'm going to remove |
Remove the "IPv6NodePrefixLen" const (=96), as from now we can allocate IPv6 addrs from any size CIDR. The const is only used by a case when an IPv6 allocation range is derived from "ipv6-cluster-alloc-cidr" and "ipv4-range" Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
test-me-please |
tgraf
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the IPv6
/96prefix constraint which allows cilium to be used with k8s in the dual-stack mode.Previously, the DSR for IPv6 (aka the
--lbfeature) required the--ipv6-rangeto be /96. This was because the 113-128 bits of an IPv6 addr were used to store a global reverse NAT ID, and the rest was a unique Pod IPv6 addr.As the
--lbfeature was removed, the constraint is no longer needed (the new DSR implementation leverages IPv6 extension field to store a SVC IP addr and port).Tested manually with kubeadm (
kubeadm init --skip-phases=addon/kube-proxy --pod-network-cidr=10.217.0.0/16,fc22::/48 --service-cidr=10.96.0.0/16,fc44::/112 --feature-gates IPv6DualStack=true --apiserver-advertise-address=192.168.34.11).This change is