cmd: add zsh as a option for completion #9882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 16, 2020
rolinh
added
the
area/cli
|
Release note label not set, please set the appropriate release note. |
|
Thanks for your first contribution! LGTM overall, I'd just change the call as mentioned in the comment above. |
rolinh
added
the
release-note/minor
rolinh
approved these changes
Jan 16, 2020
aanm
approved these changes
Jan 16, 2020
|
test-me-please |
joestringer
approved these changes
Jan 21, 2020
added 2 commits
January 21, 2020 08:09
This adds zsh as a option for command completion, for zsh is also popular and cobra natively supports zsh. This will not change the default behavior of "completion" command. If no or "bash" argument specified, it generates the completion for bash. Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
This replaces Command.Run() with Command.RunE(), which exposes the error to the outer scope, then the rootCmd.Execute() could catch this error and print the error message with exit code -1. Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
tonyluj
force-pushed
the
completion-support-zsh
branch
from
6aacdcb
to
5f90e65
Compare
|
Commit f957815adbc392884e15f26da57c70ed31d951b0 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/contributing/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
tonyluj
force-pushed
the
completion-support-zsh
branch
from
f957815
to
5f90e65
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
@aanm |
|
test-me-please |
|
test-me-please |
aanm
approved these changes
Jan 21, 2020
tklauser
added a commit
to cilium/hubble
that referenced
this pull request
Mar 1, 2020
Add zsh as an option for hubble command completion. The default behavior of the `completition` command is still bash completition, i.e. if no argument or `bash` is specified. The same was added to the `cilium` command in cilium/cilium#9882 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added a commit
to cilium/hubble
that referenced
this pull request
Mar 1, 2020
Add zsh as an option for hubble command completion. The default behavior of the `completition` command is still bash completition, i.e. if no argument or `bash` is specified. The same was added to the `cilium` command in cilium/cilium#9882 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
michi-covalent
pushed a commit
to cilium/hubble
that referenced
this pull request
Mar 2, 2020
Add zsh as an option for hubble command completion. The default behavior of the `completition` command is still bash completition, i.e. if no argument or `bash` is specified. The same was added to the `cilium` command in cilium/cilium#9882 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds zsh as a option for command completion, for zsh is also
popular and cobra natively supports zsh.
This will not change the default behavior of "completion" command.
If no or "bash" argument specified, it generates the completion for
bash.
Signed-off-by: Tony Lu tonylu@linux.alibaba.com
This change is