Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Delete Cilium DS before changing startup options. #9891

Merged
merged 1 commit into from
Jan 17, 2020
Merged

test: Delete Cilium DS before changing startup options. #9891

merged 1 commit into from
Jan 17, 2020

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Jan 16, 2020 •
edited by tgraf
Loading

Signed-off-by: Jarno Rajahalme jarno@covalent.io

This change is Reviewable

@jrajahalme
test: Delete Cilium DS before changing startup options.
d51d1c0 
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added pending-review kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jan 16, 2020
@jrajahalme jrajahalme requested a review from a team as a code owner January 16, 2020 18:39
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.7.0 Jan 16, 2020
@jrajahalme
Copy link
Member Author

test-me-please

soumynathan
soumynathan reviewed Jan 16, 2020
View reviewed changes
Copy link
Contributor

@soumynathan soumynathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 45.907% when pulling d51d1c0 on pr/jrajahalme/test-restart-cilium into abcfef6 on master.

@aanm aanm merged commit b454a02 into master Jan 17, 2020
1.7.0 automation moved this from In progress to Merged Jan 17, 2020
@aanm aanm deleted the pr/jrajahalme/test-restart-cilium branch January 17, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumynathan soumynathan soumynathan left review comments

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.7.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrajahalme @coveralls @aanm @soumynathan