policy: Error out on missing secrets in policy computation #9897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently missing secrets cause empty TLS contexts to be sent to Envoy, which will then NACK the policy. Error out earlier in the Cilium endpoint regeneration logic so that Envoy is not bothered with errorneous configuration. Currently this will still lead to endpoint being not-ready, but at least the endpoint log contains the failure message pinpointing the problem (e.g., "Error regenerating endpoint: unable to regenerate policy for '310': secrets \"swapi-server\" not found"). Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
kind/enhancement
|
Release note label not set, please set the appropriate release note. |
2 similar comments
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
houndci-bot
reviewed
Jan 17, 2020
| } | ||
| case OriginatingTLS: | ||
| if ca == "" { | ||
| return nil, fmt.Errorf("Originating TLS context is missing CA certs.") |
There was a problem hiding this comment.
error strings should not be capitalized or end with punctuation or a newline
| switch direction { | ||
| case TerminatingTLS: | ||
| if public == "" || private == "" { | ||
| return nil, fmt.Errorf("Terminating TLS context is missing certs.") |
There was a problem hiding this comment.
error strings should not be capitalized or end with punctuation or a newline
| type TLSDirection string | ||
|
|
||
| const ( | ||
| TerminatingTLS TLSDirection = "terminating" |
There was a problem hiding this comment.
exported const TerminatingTLS should have comment (or a comment on this block) or be unexported
| @@ -390,19 +390,40 @@ func (l7 L7DataMap) addRulesForEndpoints(rules api.L7Rules, endpoints []CachedSe | |||
| } | |||
| } | |||
|
|
|||
| func (l4 *L4Filter) getCerts(policyCtx PolicyContext, tls *api.TLSContext, direction string) *TLSContext { | |||
| type TLSDirection string | |||
There was a problem hiding this comment.
exported type TLSDirection should have comment or be unexported
jrajahalme
added
the
release-note/misc
|
test-me-please |
aanm
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently missing secrets cause empty TLS contexts to be sent to
Envoy, which will then NACK the policy. Error out earlier in the
Cilium endpoint regeneration logic so that Envoy is not bothered with
errorneous configuration.
Currently this will still lead to endpoint being not-ready, but at
least the endpoint log contains the failure message pinpointing the
problem (e.g., "Error regenerating endpoint: unable to regenerate
policy for '310': secrets "swapi-server" not found").
Signed-off-by: Jarno Rajahalme jarno@covalent.io
This change is