Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CILIUM_REGISTRY in provisioning scritps #9991

Merged
merged 1 commit into from Jan 29, 2020
Merged

Set CILIUM_REGISTRY in provisioning scritps #9991

merged 1 commit into from Jan 29, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented Jan 29, 2020 •
edited by tgraf

This change is Reviewable

@nebril nebril requested a review from a team as a code owner January 29, 2020 12:05
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.7.0 Jan 29, 2020
@nebril
Copy link
Member Author

nebril commented Jan 29, 2020

test-me-please

@coveralls
Copy link

coveralls commented Jan 29, 2020 •
edited

Coverage Status

Coverage decreased (-0.003%) to 45.738% when pulling 39c992e on pr/dont-build-images-in-ci-vms into 2eb2d0d on master.

@nebril nebril force-pushed the pr/dont-build-images-in-ci-vms branch from d589b37 to 38f03fb Compare January 29, 2020 12:30
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@nebril nebril force-pushed the pr/dont-build-images-in-ci-vms branch from 38f03fb to 133f8c7 Compare January 29, 2020 12:32
@nebril
Copy link
Member Author

nebril commented Jan 29, 2020

test-me-please

@nebril nebril changed the title wip Set CILIUM_REGISTRY in provisioning scritps Jan 29, 2020
@nebril nebril added pending-review release-note/ci This PR makes changes to the CI. labels Jan 29, 2020
@nebril nebril force-pushed the pr/dont-build-images-in-ci-vms branch from 133f8c7 to 8fc45c7 Compare January 29, 2020 13:08
@nebril
Copy link
Member Author

nebril commented Jan 29, 2020

test-me-please

@nebril
Set CILIUM_REGISTRY in provisioning scritps
39c992e 
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/dont-build-images-in-ci-vms branch from 8fc45c7 to 39c992e Compare January 29, 2020 16:05
@nebril
Copy link
Member Author

nebril commented Jan 29, 2020

test-me-please

@aanm aanm merged commit 16a7c80 into master Jan 29, 2020
1.7.0 automation moved this from In progress to Merged Jan 29, 2020
@aanm aanm deleted the pr/dont-build-images-in-ci-vms branch January 29, 2020 17:56
@gandro gandro mentioned this pull request Jan 30, 2020
Merged
2 tasks
gandro added a commit that referenced this pull request Jan 31, 2020
@gandro
Set CILIUM_REGISTRY in k8s provisioning scripts
e419415 
Follow-up of #9991, applying its changes to the k8s Jenkinsfile as well.
This is required for the Cilium-PR-Ginkgo-Tests-K8s test suite to pass.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro mentioned this pull request Jan 31, 2020
Merged
gandro added a commit that referenced this pull request Feb 3, 2020
@gandro
Set CILIUM_REGISTRY in k8s provisioning scripts
18c0032 
Follow-up of #9991, applying its changes to the k8s Jenkinsfile as well.
This is required for the Cilium-PR-Ginkgo-Tests-K8s test suite to pass.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.7.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nebril @coveralls @aanm