Add README.md and template #2
Conversation
cfps/CFP-002-template.md
Outdated
| **Cilium Release:** X.XX | ||
|
|
||
| **Authors:** alice <alice@example.com>, bob jones <bob@example.com> | ||
|
|
There was a problem hiding this comment.
Having some form of "State" field (like "provisional", "implementable", "implemented") is useful because it allows us to merge an early design and update it later if we want. (We can just go straight to implemented though).
This one's non-blocking though, it's just been nice in other places.
There was a problem hiding this comment.
I've created #4 to track this and have the conversation there
README.md
Outdated
| file as an outline. The structure of this template is meant to provide a starting | ||
| point for people. Feel free to edit and modify your outline to best fit your | ||
| needs when creating a proposal. The title should be `CFP-###-subject.md` | ||
| where the number is the CFP issue number. |
There was a problem hiding this comment.
How does a contributor know what the "CFP issue number" is?
Should contributors open a new issue first, or should they open a blank PR and then update it to pick a number? (How does k8s do this? 🤔 )
There was a problem hiding this comment.
k8s has you open an issue first, and uses that as the basis.
There was a problem hiding this comment.
Another question from me: What about design proposal for Cilium org repos other than cilium/cilium? I guess the simplest answer here is that the process is something like this:
- Create a CFP issue in the repo your design applies to. (ie, cilium/cilium, cilium/tetragon, etc)
- Create the file in this repo, with a path of
cfps/<repo>/CFP-####-subject.md. - Merging the file into this repo constitutes acceptance of the design (or something to that effect).
This is imposing this requirement on other projects (like Tetragon), but I suspect that's going to end up a win in the longer term.
There was a problem hiding this comment.
I've tried to capture this below. # 3 should be covered in "getting a designed approved" below.
I don't think this is actually imposing a requirement on other projects because they could decided to do something else and we would end up with just a cilium folder
|
That's everything I can think of, this LGTM. Looking forward to bringing the mTLS CFP in here. 🙂 |
xmulligan
force-pushed
the
xmulligan-patch-1
branch
from
a65fe50
to
7a45634
Compare
Something terrrible happened in Git in #1
As discussed in the January 25th community meeting and cilium/cilium#23690, this folder will let us keep track of CFP for future design discussions.