Skip to content

Commit

Permalink
CI: update golangci-lint version
Browse files Browse the repository at this point in the history
The latest version is v1.42.1 so move to use that. Drop "prealloc"
from the list of "could be enabled later" after evaluating its
usefulness and based on the golangci-lint suggestion:

"XXX: we don't recommend using this linter before doing performance profiling.
For most programs usage of prealloc will be a premature optimization."

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
  • Loading branch information
mythi authored and ti-mo committed Sep 29, 2021
1 parent 1fb2d63 commit d2a0bbe
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion .golangci.yaml
Expand Up @@ -24,6 +24,5 @@ linters:

# Could be enabled later:
# - gocyclo
# - prealloc
# - maligned
# - gosec
2 changes: 1 addition & 1 deletion .semaphore/semaphore.yml
Expand Up @@ -23,7 +23,7 @@ blocks:
- sudo mkdir -p /usr/local/golang/1.17 && curl -fL "https://golang.org/dl/go1.17.linux-amd64.tar.gz" | sudo tar -xz -C /usr/local/golang/1.17
- sem-version go 1.17
- go install github.com/mattn/goveralls@latest
- curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.38.0
- curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.42.1
- export PATH="$PATH:$(go env GOPATH)/bin"
- cache restore
- go mod tidy
Expand Down

0 comments on commit d2a0bbe

Please sign in to comment.