Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate tests to github.com/go-quicktest/qt #1251

Closed
lmb opened this issue Dec 5, 2023 · 0 comments · Fixed by #1253
Closed

migrate tests to github.com/go-quicktest/qt #1251

lmb opened this issue Dec 5, 2023 · 0 comments · Fixed by #1253
Assignees
@sayboras
Labels
good first issue Good for newcomers

Comments

@lmb
Copy link
Collaborator

lmb commented Dec 5, 2023

We currently use https://github.com/frankban/quicktest in our test suite. The API is full of any parameters and therefore needs some annoying work arounds when comparing non-int values:

qt.Assert(t, foo, qt.Equals, uint32(2))

We also rename the import from quicktest to qt.

There is a new "version" of the package which uses generics instead: https://github.com/go-quicktest/qt Migrate our testsuite to use the new qt package.
@lmb lmb added the good first issue Good for newcomers label Dec 5, 2023
sayboras added a commit to sayboras/ebpf that referenced this issue Dec 5, 2023
@sayboras
test: Migrate tests to github.com/go-quicktest/qt
7c93e5f 
Fixes: cilium#1251
@sayboras sayboras mentioned this issue Dec 5, 2023
Merged
sayboras added a commit to sayboras/ebpf that referenced this issue Dec 6, 2023
@sayboras
test: Migrate tests to github.com/go-quicktest/qt
8442057 
Fixes: cilium#1251
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/ebpf that referenced this issue Dec 6, 2023
@sayboras
test: Migrate tests to github.com/go-quicktest/qt
65f14af 
Fixes: cilium#1251
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/ebpf that referenced this issue Dec 6, 2023
@sayboras
test: Migrate tests to github.com/go-quicktest/qt
3216ece 
Fixes: cilium#1251
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/ebpf that referenced this issue Dec 6, 2023
@sayboras
test: Migrate tests to github.com/go-quicktest/qt
074f816 
Fixes: cilium#1251
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@lmb lmb closed this as completed in #1253 Dec 6, 2023
lmb pushed a commit that referenced this issue Dec 6, 2023
@sayboras @lmb
test: Migrate tests to github.com/go-quicktest/qt
81ea056 
Fixes: #1251
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sayboras sayboras

Labels
good first issue Good for newcomers
Projects
Good First Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Migrate tests to github.com/go-quicktest/qt sayboras/ebpf
2 participants
@lmb @sayboras