btf: clean up some small things #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Spec always has a string table now that NewSpec is not a thing anymore. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Move btfHeader so that all btf* types live in the same file. This reduces the size of btf.go as well. No other changes intended. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
There is an upstream fix and we have a workaround for the Datasec issue. Don't skip it in tests anymore. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Reading a string table uses a custom function to search a []uint32 since that made a measurable difference back in time. Instead of copying the implementation we can now use the generic slices.BinarySearch. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
rgo3
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits have languished in a branch of mine for a while. I think they're good to go in on their own.
btf: remove newSpec
btf: Spec.strings can't be nil anymore
btf: move btfHeader to btf_types.go
btf: don't skip per-CPU datasec in tests anymore
btf: use slices.BinarySearch when reading a string table