Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 6.6 to CI #1187

Merged
merged 3 commits into from
Oct 30, 2023
Merged

add 6.6 to CI #1187

merged 3 commits into from
Oct 30, 2023

Conversation

lmb
Copy link
Collaborator

@lmb lmb commented Oct 30, 2023

elf: make the error for weak map definitions less confusing

Trying to load an ELF with a weak map definition currently gives a confusing
error:

    relocating instruction: possible erroneous static qualifier on
   map definition: found reference to "__bpf_usdt_ip_to_spec_id"

The error dates back to when weak references were not a thing. Only return
that error when the binding is really STB_LOCAL aka static.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

btf: fix enum64 CO-RE relocations

Using CO-RE to do enum64 relocations is currently broken, since our internal
representation of a relocation only carries 32 bit of expected constant
value.

Fix this by extending the field to 64 bit and add a test.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

CI: test against 6.6

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

Trying to load an ELF with a weak map definition currently gives
a confusing error:

    relocating instruction: possible erroneous static qualifier on
    map definition: found reference to "__bpf_usdt_ip_to_spec_id"

The error dates back to when weak references were not a thing.
Only return that error when the binding is really STB_LOCAL aka
static.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Using CO-RE to do enum64 relocations is currently broken, since
our internal representation of a relocation only carries 32 bit of
expected constant value.

Fix this by extending the field to 64 bit and add a test.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb requested a review from ti-mo October 30, 2023 12:26
@ti-mo ti-mo merged commit 3b9d47a into cilium:main Oct 30, 2023
13 checks passed
@lmb lmb deleted the ci-add-6.6 branch October 31, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants