Add BTFIDLink to support fentry/fexit/fmod_ret/tp_raw/lsm BPF programs #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
reviewed
Oct 29, 2021
link/btf_id.go
Outdated
| var _ Link = (*BTFIDLink)(nil) | ||
|
|
||
| // BTFIDLink is a program attached to a btf_id. | ||
| type BTFIDLink struct { |
There was a problem hiding this comment.
I think it's better to unexport this and return Link instead of *BTFIDLink below. Rationale:
- BTFIDLink doesn't expose user accessible methods, so returning
Linkis fine. - We can later change functions to return a concrete type without breaking callers.
- This means we don't have to commit to the name yet, and we don't have to commit to using the same type for LSM and Trace programs.
There was a problem hiding this comment.
Addressed in f2db4e6
|
Please rebase on master to make CI run against 5.14. Thanks! |
|
@lmb I recompiled kernel 5.14.14 with adding the below to the config and the tests passed at my local vm through run-tests.sh 5.14 ./link |
lmb
approved these changes
Nov 1, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attachBTFID links Tracing/LSM BPF programs which they attach to a btf_id.