Add v5.14 to CI builds #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asm.Instruction only supports %v, not %s.
We currently have a failing test that is skipped on all CI builds, since it specifies a minimum version higher than the maximum version we test against. Prevent this from happening again by failing tests that are never executed.
lmb
commented
Oct 26, 2021
| @@ -66,6 +66,10 @@ func TestHaveProgType(t *testing.T) { | |||
| } | |||
| testutils.SkipOnOldKernel(t, minVersion, feature) | |||
|
|
|||
| if pt == ebpf.Syscall { | |||
| t.Skip("HaveProgType(Syscall) is broken on 5.14") | |||
There was a problem hiding this comment.
cc @rgo3 this needs some looking at, seems like the feature test doesn't actually work.
There was a problem hiding this comment.
Sure, I've opened an issue (#464) to keep track and will look into it asap (feel free to assign me). Since the program type is quite new, and bpftool doesn't have a probe for it either I'll have to check the kernel code to figure out how to fix it. Once this PR is merged I can use the new CI kernel to debug the issue as I don't have 5.14 installed locally.
|
cc @mehrdadrad this will unblock your PR. |
lmb
commented
Oct 27, 2021
| t.Skip("Skipping due to missing InnerMap in map definition") | ||
| case "test_core_autosize.o": | ||
| t.Skip("Skipping since the test generates dynamic BTF") | ||
| case "for_each_array_map_elem.o", "for_each_array_map_elem.linked3.o", | ||
| "for_each_hash_map_elem.o", "for_each_hash_map_elem.linked3.o": | ||
| t.Skip("Skipping since function pointers are not supported") |
lmb
commented
Oct 27, 2021
| case "test_static_linked.linked3.o": | ||
| t.Skip("Skipping since .text contains 'subprog' twice") | ||
| case "linked_maps.linked3.o", "linked_funcs.linked3.o": | ||
| t.Skip("Skipping since weak relocations are not supported") |
ti-mo
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of new features that break integration tests:
There is also a bunch of stuff around static linking of objects which I don't understand. Not sure if that is a bug in libbpf or a feature I don't understand.