features: fix HaveProgType(ebpf.Syscall) #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPF Syscall programs need to be sleepable which is enforced by the verifier. So we need to set the correct program flags before executing the feature probe. Fixes cilium#464. Signed-off-by: Robin Gögge <r.goegge@gmail.com>
florianl
approved these changes
Oct 30, 2021
|
No worries, when we added those tests we hoped they would just automatically fail when new prog types are added, forcing people to ensure the feature probe for that type also works. But if no CI kernel for that feature exists yet its skipped and one can get away without making sure the probes actually work. I think that's what happened here, even though you actually had thought about the feature tests and added the right kernel version to the test matrix. |
lmb
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BPF Syscall programs need to be sleepable which is enforced by the
verifier. So we need to set the correct program flags before executing
the feature probe.
Fixes #464.
Signed-off-by: Robin Gögge r.goegge@gmail.com