Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: prefer podman for container engine #480

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Makefile: prefer podman for container engine #480

merged 2 commits into from
Nov 15, 2021

Conversation

loshz
Copy link
Contributor

@loshz loshz commented Nov 9, 2021

Ref: #479

Usage:

# If podman is found on the system, then it is preferred. Otherwise fall back to using docker.
# Passing the variable at runtime will always take precedence:
$ command -v podman
/bin/podman
$ CONTAINER_ENGINE=docker make container-all
docker run --rm --user "1000:985" \
...
$ make container-all
podman run --rm  \
...
# Override container run args
$ CONTAINER_RUN_ARGS='--user "1000:985"' make container-all
podman run --rm --user "1000:985" \
...
# Override both
$ CONTAINER_ENGINE=docker CONTAINER_RUN_ARGS='--name=cilium-ebpf' make container-all
docker run --rm --name=cilium-ebpf \
...

Makefile Outdated Show resolved Hide resolved
@loshz loshz requested review from lmb and mmat11 November 13, 2021 01:12
@lmb lmb merged commit 30a296c into cilium:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants