cmd/bpf2go: strip DWARF info #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
lmb/bpf2go-strip
branch
from
c98fd01
to
d000b16
Compare
brycekahle
reviewed
Nov 15, 2021
lmb
force-pushed
the
lmb/bpf2go-strip
branch
from
d000b16
to
b31b8bd
Compare
lmb
force-pushed
the
lmb/bpf2go-strip
branch
2 times, most recently
from
d7f86fb
to
a5cc12a
Compare
ti-mo
approved these changes
Nov 16, 2021
The compiled ELF contain DWARF debug info, which isn't used by the BPF toolchain. Strip the debug info by default. Passing -no-strip disables stripping. Fixes #429
Move the example into a separate package and rename it to test. Now that we have examples in the project root it's not a great resource anymore. We still need it to make sure we don't regress on the generate API however.
Also strip dwarf info from precompiled testdata.
lmb
force-pushed
the
lmb/bpf2go-strip
branch
from
75c6525
to
70bde92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiled ELF contain DWARF debug info, which isn't used by the
BPF toolchain. Strip the debug info by default. Passing -strip=""
disables stripping.
Fixes #429