Link: add XDP support #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
requested changes
Nov 12, 2021
lmb
requested changes
Nov 15, 2021
lmb
reviewed
Nov 17, 2021
link/xdp.go
Outdated
| // Interface is the interface index to attach program to. | ||
| Interface int | ||
|
|
||
| // Flags must match the attach flag of XDP. |
There was a problem hiding this comment.
Is that correct? I think you can load XDP without any flags and still force XDPDriverMode when attaching (at least that's possible via netlink).
There was a problem hiding this comment.
It explained more right after this line:
// Only one XDP mode should be set, without flag defaults
// to driver/generic mode (best effort).
but I just rephrased it line#29 please let me know if you want it something else.
link/xdp_test.go
Outdated
| const IfIndexLO = 1 | ||
|
|
||
| func TestAttachXDP(t *testing.T) { | ||
| testutils.SkipOnOldKernel(t, "5.7", "BPF_LINK_TYPE_XDP") |
There was a problem hiding this comment.
This appeared in 5.9 I think torvalds/linux@aa8d3a7
|
|
||
| l, err := AttachXDP(XDPOptions{ | ||
| Program: prog, | ||
| Interface: IfIndexLO, |
There was a problem hiding this comment.
We don't need: https://github.com/torvalds/linux/blob/master/tools/testing/selftests/bpf/prog_tests/xdp_link.c#L7
But if you want I can add this instead.
link/xdp_test.go
Outdated
| }, | ||
| }) | ||
|
|
||
| err = l.Close() |
There was a problem hiding this comment.
Not necessary, testLink closes the link I think.
lmb
approved these changes
Nov 17, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new API: AttachXDP links an XDP program to an interface through BPF_LINK_CREATE.