link: add LoadPinnedLink #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
lmb/load-pinned-link
branch
from
90ac002
to
c301abe
Compare
|
Line 168 in c301abe return nil, fmt.Errorf("get pinned link info: %w", err) |
mehrdadrad
reviewed
Nov 18, 2021
mehrdadrad
reviewed
Nov 18, 2021
link/link_test.go
Outdated
| return LoadPinnedRawLink(f, UnspecifiedType, opts) | ||
| }, | ||
| }) | ||
| testLink(t, link, prog) |
There was a problem hiding this comment.
Suggested change
| testLink(t, link, prog) | |
| testLink(t, &linkCgroup{*link}, prog) |
Add a function that allows loading any pinned link. This allows us to deprecate all of the separate LoadPinned* functions. In the future we can use LoadPinnedLink to build APIs that work with any kind of link.
lmb
force-pushed
the
lmb/load-pinned-link
branch
from
c301abe
to
30ac9ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function that allows loading any pinned link. This allows us to
deprecate all of the separate LoadPinned* functions. In the future we
can use LoadPinnedLink to build APIs that work with any kind of link.