cmd/bpf2go: infer llvm-strip suffix from clang binary #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm is often available in multiple versions, with binaries having the
major version attached as a suffix, for example clang-13. Since adding
stripping it's now necessary to pass two flags when using such
versioned binaries:
bpf2go -cc clang-13 -strip llvm-strip-13 ...
Add a heuristic which derives the version suffix from the clang binary
and uses that to look for llvm-strip. This allows skipping the -strip
flag in the example above.
ti-mo
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm is often available in multiple versions, with binaries having the
major version attached as a suffix, for example clang-13. Since adding
stripping it's now necessary to pass two flags when using such
versioned binaries:
Add a heuristic which derives the version suffix from the clang binary
and uses that to look for llvm-strip. This allows skipping the -strip
flag in the example above.