map: allow empty ProgramArray to not be assigned #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurfabre
approved these changes
Dec 1, 2021
xdpcap [1] used ProgramArrays to implement hooks in XDP programs. So far, it's been possible to add an xdpcap hook without calling into the library to patch the ProgramArray. The change to support pre-populating tail call maps broke this, since we now don't allow ProgramArrays which are loaded but not requested by the user. However, this case it is OK for the ProgramArray to be closed since there are no programs in it anyways. Make the error less strict by allowing empty ProgramArrays to be unassigned. 1: https://github.com/cloudflare/xdpcap
ti-mo
force-pushed
the
lmb/prog-array-error
branch
from
6a03166
to
f90747c
Compare
ti-mo
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xdpcap [1] used ProgramArrays to implement hooks in XDP programs.
So far, it's been possible to add an xdpcap hook without calling
into the library to patch the ProgramArray. The change to support
pre-populating tail call maps broke this, since we now don't allow
ProgramArrays which are loaded but not requested by the user.
However, this case it is OK for the ProgramArray to be closed since
there are no programs in it anyways. Make the error less strict by
allowing empty ProgramArrays to be unassigned.
1: https://github.com/cloudflare/xdpcap