asm: Add Jump32 support #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurfabre
force-pushed
the
afabre/jump32
branch
from
3406732
to
fbe566e
Compare
|
Fixed a typo in a test. |
arthurfabre
force-pushed
the
afabre/jump32
branch
from
fbe566e
to
7103a0e
Compare
|
I force pushed to re-run the tests, but CI failed again with: I'll try again in a bit. |
lmb
requested changes
Dec 3, 2021
linker.go
Outdated
| @@ -121,7 +121,7 @@ func fixupJumpsAndCalls(insns asm.Instructions) error { | |||
|
|
|||
| ins.Constant = int64(callOffset - offset - 1) | |||
|
|
|||
| case ins.OpCode.Class() == asm.JumpClass && ins.Offset == -1: | |||
| case ins.OpCode.JumpOp() != asm.InvalidJumpOp && ins.Offset == -1: | |||
There was a problem hiding this comment.
I find this harder to read. How about assing Class.IsJump() and then doing the following:
Suggested change
| case ins.OpCode.JumpOp() != asm.InvalidJumpOp && ins.Offset == -1: | |
| case ins.OpCode.Class().IsJump() && ins.Offset == -1: |
We could apply IsJump, IsALU in other places as well.
There was a problem hiding this comment.
Good idea! Added a commit to introduce these, and IsStore(), IsLoad() as well.
|
Ping @arthurfabre do you want to pick this up again? |
arthurfabre
force-pushed
the
afabre/jump32
branch
from
7103a0e
to
d3bff48
Compare
Stores, loads, jumps, and ALU operations can all be represented by two different classes. Add helpers so callers don't have to remember to check both classes. Use the new helpers in all the OpCode setters and getters. This validates classes a bit stricter than previously: ALUClass.JumpOp() would have returned a ALUOp decoded as a JumpOp. It now returns InvalidALUOp.
The unused 0x6 class now represents jumps with 32bit comparisons: https://lore.kernel.org/all/1548523574-18316-16-git-send-email-jiong.wang@netronome.com/T/ http://patchwork.ozlabs.org/project/netdev/list/?series=88386&state=* This complements 32bit ALU operations by allowing comparisons without having to sign extend registers beforehand. Add a Jump32Class to represent this. As some JumpOps are not supported by Jump32 (Call, Exit, Ja), centralize the logic for validating jump OpCodes in OpCode.JumpOp().
arthurfabre
force-pushed
the
afabre/jump32
branch
from
d3bff48
to
71df43f
Compare
lmb
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unused 0x6 class now represents jumps with 32bit comparisons:
https://lore.kernel.org/all/1548523574-18316-16-git-send-email-jiong.wang@netronome.com/T/
http://patchwork.ozlabs.org/project/netdev/list/?series=88386&state=*
This complements 32bit ALU operations by allowing comparisons without
having to sign extend registers beforehand.
Add a Jump32Class to represent this. As some JumpOps are not supported
by Jump32 (Call, Exit, Ja), centralize the logic for validating jump
OpCodes in OpCode.JumpOp().