Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btf: support raw BTF in LoadSpecFromReader #520

Merged
merged 3 commits into from
Dec 10, 2021
Merged

btf: support raw BTF in LoadSpecFromReader #520

merged 3 commits into from
Dec 10, 2021

Conversation

lmb
Copy link
Collaborator

@lmb lmb commented Dec 7, 2021

Allow passing BTF not wrapped in an ELF to LoadSpecFromReader. This
allows users to use external BTF for vmlinux, which is usually shipped
without the ELF.

@lmb lmb requested review from brycekahle and ti-mo December 7, 2021 16:21
internal/btf/btf_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this would add some nice flexibility. Left a minor comment, I think we can get away with less code.

internal/btf/btf.go Show resolved Hide resolved
internal/btf/btf_test.go Outdated Show resolved Hide resolved
@lmb
Copy link
Collaborator Author

lmb commented Dec 9, 2021

This is good to go if someone has time for a look.

Copy link
Collaborator

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, looks great!

internal/btf/btf.go Outdated Show resolved Hide resolved
Allow passing BTF not wrapped in an ELF to LoadSpecFromReader. This
allows users to use external BTF for vmlinux, which is usually shipped
without the ELF.
@ti-mo ti-mo merged commit 48bf2ba into master Dec 10, 2021
@ti-mo ti-mo deleted the lmb/raw-btf branch December 10, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants