tidy up examples #521
Merged
tidy up examples #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not necessary to keep the .c file in a subfolder if you add a
// +build ignore
to the top of the file. Move the .c next to the .go and rename the
files to be consistent with the example name.
Get rid of the init() function since there is no need for it. Also fix a missing File.Close() in detectCgroupPath.
SIGTERM handlers are useful for examples which use ringbuffers, since they demonstrate how to exit from the blocking Read() call. They're not useful in examples which just read from a map. Drop the signal handlers from such examples.
ti-mo
force-pushed
the
lmb/simplify-examples
branch
from
7163007
to
1f79593
Compare
ti-mo
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up a couple of small things which have been bugging me for a bit.