cmd/bpf2go: allow to specify native target #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to invoke `bpf2go` to build for the native architecture and
have `__TARGET_ARCH_xxx` defined based on `GOARCH` without having to
derive the architecture e.g. as part of the build system.
For example this would be useful in github.com/cilium/pwru:
//go:generate go run github.com/cilium/ebpf/cmd/bpf2go -cc clang -target native KProbePWRU ./bpf/kprobe_pwru.c -- -DOUTPUT_SKB -I./bpf/headers
Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
bpf2go-native-target
branch
2 times, most recently
from
4abcf4a
to
ab5dbf0
Compare
brb
pushed a commit
to cilium/pwru
that referenced
this pull request
Dec 17, 2021
This allows to get the PT_REGS_* macros for the correct target architecture, e.g. ARM64. Note, that currently the //go:generate lines have to be specified per GOARCH in order to set __TARGET_ARCH_xxx correctly. This can be replaced by adding `-target native` to the bpf2go call once the private fork of cilium/ebpf has been rebased to include cilium/ebpf#526. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to invoke
bpf2goto build for the native architecture andhave
__TARGET_ARCH_xxxdefined based onGOARCHwithout having toderive the architecture e.g. as part of the build system.
For example this would be useful in github.com/cilium/pwru: