Remove BTF type IDs on map creation if not supported #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In libbpf commit 962f24137978 ([0]), we teach libbpf to recognize BPF maps that do not support BTF-defined key/value and remove BTF type IDs quietly on map creation. Make ebpf library support this feature. [0]: libbpf/libbpf@962f241 Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
go-staticcheck complains that the unused receiver name should be omitted. Remove it. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Removes the btfDisabled flag in createMap() to make the logic a bit leaner. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
fix-btf-key-value
branch
from
005039f
to
337c7ab
Compare
|
Hi @chenhengqi, thanks for the patch! I've pushed a small helper to your branch to simplify the logic at the end of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libbpf commit 962f24137978 (0), we teach libbpf to recognize
BPF maps that do not support BTF-defined key/value and remove
BTF type IDs quietly on map creation. Make ebpf library support
this feature.