link/kprobe: specify symbol offset #613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonghao Zhang <zhangtonghao@didiglobal.com>
mmat11
reviewed
Mar 29, 2022
Signed-off-by: Tonghao Zhang <zhangtonghao@didiglobal.com>
mmat11
approved these changes
Mar 30, 2022
ti-mo
requested changes
Mar 30, 2022
| @@ -49,6 +49,8 @@ type KprobeOptions struct { | |||
| // | |||
| // Needs kernel 5.15+. | |||
| Cookie uint64 | |||
| // Kprobe symbol offset. | |||
There was a problem hiding this comment.
This needs more context. How is it used? Why is it necessary? How would the caller determine the correct offset to use?
There was a problem hiding this comment.
Hi, This offset is used for kprobe, because some functions in kernel is static or inline, we can't insert one probe. but we can use probe the caller with offset. This "offset" is same as tracefs kprobe_events
https://www.kernel.org/doc/html/latest/trace/kprobetrace.html
There was a problem hiding this comment.
Suggested change
| // Kprobe symbol offset. | |
| // Offset of the kprobe relative to the traced symbol. | |
| // Can be used to insert kprobes at arbitrary offsets in kernel functions, | |
| // e.g. in places where functions have been inlined. |
|
Adding a test similar to |
ti-mo
changed the title
Signed-off-by: Tonghao Zhang <zhangtonghao@didiglobal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tonghao Zhang zhangtonghao@didiglobal.com